Adding basic Rust CI infrastructure #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swernli
changed the title
bamarsha
approved these changes
Jan 31, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
This PR adds the ability to declare custom measurements in Q#. Here is an example: ```qsharp @measurement() operation __quantum__qis__mx__body(target : Qubit) : Result { body intrinsic; } ``` The generated QIR will be, ```llvm-ir declare void @__quantum__qis__mx__body(%Qubit*, %Result*) #1 ``` # Design Notes 1. I choose the `@Measurement()` attribute over a new `measurement` keyword to avoid putting extra syntax into the language. 2. A custom measurement must be a `body intrinsic` or a `@SimulatableIntrinsic()`. 3. A measurement must only take `Qubits` as inputs and have `Results` as outputs. # Notes to reviewers This PR consists of the following steps: 1. Adding a `@Measurement()` attribute to the language and piping it down to FIR. 3. Make the generated QIR have the `#1` attribute indicating an irreversible operation. 4. Treating a measurement as a dynamic operation in RCA. 5. Handling custom measurements correctly during partial evaluation: moving the output Results to result registers in the input. 6. Handling undesired semantics as errors using an HIR pass. 7. Adding the `@Measurement()` attribute to the completions list. 8. Unit tests in codegen and in the HIR pass. # Next steps After this PR is merged we can add the `@Measurement()` attribute to the measurement operations in the standard library and remove the hard coded logic we have for them in the compiler. --------- Co-authored-by: Stefan J. Wernli <swernli@microsoft.com> Co-authored-by: César Zaragoza Cortés <cesarzc@microsoft.com>
orpuente-MS
added a commit
that referenced
this pull request
Oct 29, 2024
orpuente-MS
added a commit
that referenced
this pull request
Oct 29, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
This PR adds support for custom resets using the `@Reset` attribute. It consists of the following changes: - Adding a `@Reset` attribute to the language. - Piping it down to FIR. - Using the attribute to generate the correct QIR, including the `"irreversible"` attribute. - Semantic validation passes in `qsc_passes` based on the `@Reset` attribute. - The right handling of reset operations during partial evaluation. - Unit tests. - Update previous tests to include the `#1` irreversible attribute in QIR when calling the Reset operation. --------- Co-authored-by: Stefan J. Wernli <swernli@microsoft.com> Co-authored-by: César Zaragoza Cortés <cesarzc@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.