Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Allow .NET 5 in global.json and build with .NET 5 in CI #841

Merged
merged 7 commits into from
Jan 29, 2021
Merged

Conversation

bamarsha
Copy link
Contributor

@bamarsha bamarsha commented Jan 27, 2021

With #821 merged, we no longer need a global.json in the root of the repository to keep the language server tests passing when .NET 5 is installed.

I'd also like to update the CI to use .NET 5, even though we aren't using any .NET 5 features yet:

  • It makes sure that the compiler can always build with .NET 5, so that when we upgrade later there won't be any surprises. Compatibility with .NET Core 3.1 is still checked by the e2e build.
  • The build supports XML validation for F# doc comments (Use the XML exception tag in doc comments (F#) #766), but only with .NET 5. This will allow CI to enforce that F# doc comments stay valid.
  • Newer versions of Fantomas (for F# formatting) have some bug fixes, but require .NET 5. (Fantomas doesn't run on the e2e build so we can still use the .NET 5 versions without updating e2e.)

@bamarsha bamarsha marked this pull request as ready for review January 27, 2021 23:10
@bettinaheim bettinaheim requested review from anjbur and vxfield January 28, 2021 04:24
@bettinaheim
Copy link
Contributor

@anjbur @vxfield for awareness and input.

Copy link
Member

@vxfield vxfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@bamarsha bamarsha merged commit 3dd0d10 into main Jan 29, 2021
@bamarsha bamarsha deleted the samarsha/net5 branch January 29, 2021 01:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants