Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos and comments. #815

Merged
merged 2 commits into from
Jan 9, 2022
Merged

Fix typos and comments. #815

merged 2 commits into from
Jan 9, 2022

Conversation

ChiahungTai
Copy link
Collaborator

Description

Fix some typos and add some comments.

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.
    N/A

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@you-n-g
Copy link
Collaborator

you-n-g commented Jan 9, 2022

Thanks so much! LGTM!

@you-n-g you-n-g merged commit bcf18c1 into microsoft:main Jan 9, 2022
@you-n-g you-n-g added the documentation Improvements or additions to documentation label Jan 12, 2022
@ChiahungTai ChiahungTai deleted the comments_init branch January 25, 2022 01:27
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
@ChiahungTai
Fix typos and comments. (microsoft#815)
22ce5f4 
* Fix typos and comments.

* Add comma before and.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChiahungTai @you-n-g