Update parsers.pyi #88
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return type of first `read_csv` implementation was wrong. In all my work, it returns a `DataFrame` for example on an `StringIO`.
jakebailey
suggested changes
Oct 8, 2021
There was a problem hiding this comment.
Marking as needing changes so this doesn't get merged while we figure out the right overloads (per #87).
|
Going to close this in favor of the changes coming in #109 (which should fix this via the right overloads). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return type of first
read_csvimplementation was wrong. In all my work, it returns aDataFramefor example on anStringIO.This solves #87