Handle non-critical exceptions in telemetry

src/LanguageServer/Impl/Implementation/Server.Telemetry.cs

@@ -13,6 +13,7 @@
 // See the Apache Version 2.0 License for specific language governing
 // permissions and limitations under the License.
 
+using System;
 using System.Diagnostics;
 using Microsoft.Python.Analysis.Analyzer;
 using Microsoft.Python.Core;
@@ -29,28 +30,34 @@ private void OnAnalysisComplete(object sender, AnalysisCompleteEventArgs e) {
                 return;
             }
 
-            double privateMB;
-            double peakPagedMB;
-            double workingMB;
+            try {
+                double privateMB;
+                double peakPagedMB;
+                double workingMB;
 
-            using (var proc = Process.GetCurrentProcess()) {
-                privateMB = proc.PrivateMemorySize64 / 1e+6;
-                peakPagedMB = proc.PeakPagedMemorySize64 / 1e+6;
-                workingMB = proc.WorkingSet64 / 1e+6;
-            }
+                using (var proc = Process.GetCurrentProcess()) {
+                    privateMB = proc.PrivateMemorySize64 / 1e+6;
+                    peakPagedMB = proc.PeakPagedMemorySize64 / 1e+6;
+                    workingMB = proc.WorkingSet64 / 1e+6;
+                }
 
-            var te = new TelemetryEvent {
-                EventName = "python_language_server/analysis_complete", // TODO: Move this common prefix into Core.
-            };
+                var te = new TelemetryEvent {
+                    EventName = "python_language_server/analysis_complete", // TODO: Move this common prefix into Core.
+                };
 
-            te.Measurements["privateMB"] = privateMB;
-            te.Measurements["peakPagedMB"] = peakPagedMB;
-            te.Measurements["workingMB"] = workingMB;
-            te.Measurements["elapsedMs"] = e.MillisecondsElapsed;
-            te.Measurements["moduleCount"] = e.ModuleCount;
-            te.Measurements["rdtCount"] = _rdt.DocumentCount;
+                te.Measurements["privateMB"] = privateMB;
+                te.Measurements["peakPagedMB"] = peakPagedMB;
+                te.Measurements["workingMB"] = workingMB;
+                te.Measurements["elapsedMs"] = e.MillisecondsElapsed;
+                te.Measurements["moduleCount"] = e.ModuleCount;
+                te.Measurements["rdtCount"] = _rdt.DocumentCount;
 
-            telemetry.SendTelemetryAsync(te).DoNotWait();
+                telemetry.SendTelemetryAsync(te).DoNotWait();
+            } catch(Exception ex) when (!ex.IsCriticalException()) {
+                // Workaround for https://github.com/microsoft/python-language-server/issues/1820
+                // On some systems random DLL may get missing or otherwise not installed
+                // and we don't want to crash b/c of telemetry.
+            }
         }
     }
 }