Fix typo: only activate.* should be counted for virtualenvs#177
Closed
collinmurch wants to merge 1 commit intomicrosoft:mainfrom
Closed
Fix typo: only activate.* should be counted for virtualenvs#177collinmurch wants to merge 1 commit intomicrosoft:mainfrom
collinmurch wants to merge 1 commit intomicrosoft:mainfrom
Conversation
karthiknadig
approved these changes
Dec 9, 2024
Collaborator
|
Unfortunately on unix, the activation script can just be a file named Please can you file an issue for this. generally we start with an issue, then create a PR that resolves the issue. E.g. we could look for files like Or perhaps we might need to revise the algorithm, e.g. clearly home brew should never be treated as virtual envs, even if they contain activation scripts. |
auto-merge was automatically disabled
December 10, 2024 02:00
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently ran into a QoL issue in VSCode where my Homebrew installations of
python3were being counted as "Virtual Environments". There are several Homebrew packages that install to the/opt/homebrew/bindirectory (where Python does) that start with the patternactivate*.For example,
activate-global-python-argcomplete.Really, we should only consider it a virtual environment directory if the activate script we look for has some arbitrary extension, not just starts with the string
activate. Hopefully this can save people in the future from going down the rabbit hole I did.