Installed stubs don't take precedence over bundled stubs

[rchiodo]

See this issue #5027

1. Install django-stubs into your environment
2. Set typechecking mode to basic
3. Add the following code to a file

from django.db import models

class MyModel(models.Model):
    nullable = models.IntegerField(null=True)

def foo():
    m = MyModel.objects.get()

    def accepts_only_int(x: int):
        pass

    accepts_only_int(m.nullable)

4. If we actually used the django-stubs, passing m.nullable to accepts_only_int shouldn't show an error.
5. If you goto declaration on models.IntegerField it will still jump into our bundled stubs.

[jmfederico]

I am seeing the same behaviour:

Tested in v2023.20.0 and v2023.21.13141007 and in both cases Pylance is choosing the bundled stubs over the installed ones.

[basicdays]

It's a very annoying workaround, but removing the bundled stubs in the extension seems to work:

• In a linux devcontainer:

  rm -rf ~/.vscode-server/extensions/ms-python.vscode-pylance-*/dist/bundled/stubs/django-stubs

• On MacOS:

  rm -rf ~/.vscode/extensions/ms-python.vscode-pylance-*/dist/bundled/stubs/django-stubs

• Not sure where the files exist on Windows. Perhaps someone would like to add a comment on how to remove those bundled type stubs.

Then reloading the window causes Pylance to find the real django-stubs that were installed. There should be an option to disable the extension's bundled stubs.

[dstansby]

👍 I'm also seeing the same issue with Matplotlib here

[paulrogov]

It's a very annoying workaround, but removing the bundled stubs in the extension seems to work:

• In a linux devcontainer:
  rm -rf ~/.vscode-server/extensions/ms-python.vscode-pylance-*/dist/bundled/stubs/django-stubs
• On MacOS:
  rm -rf ~/.vscode/extensions/ms-python.vscode-pylance-*/dist/bundled/stubs/django-stubs
• Not sure where the files exist on Windows. Perhaps someone would like to add a comment on how to remove those bundled type stubs.

Then reloading the window causes Pylance to find the real django-stubs that were installed. There should be an option to disable the extension's bundled stubs.

This workaround with removing a folder fixes RelatedManager issue (from django_stubs_ext.db.models.manager import RelatedManager works), but leads many more other type checking issues for me:

from django.utils import timezone

today = timezone.now()
tomorrow = today + timezone.timedelta(days=1) # ❌ error: timedelta is not part of timezone

# ❌it's correct syntax, but shows error here
class MyChoiceType(models.IntegerChoices):
    STUDENT = 0, "Student"
    TEACHER = 1, "Teacher"