Extension search fixes #9231
Extension search fixes #9231
Conversation
|
Question, is the logic ported from old extension code? |
|
Maybe closer to call it inspired by, closest port is here with the logic for setting the dependency here https://github.com/microsoft/pxt/blob/extensionSearchFixes/webapp/src/scriptsearch.tsx#L253 which is the main portion on using I didn't look at how the cards were displayed in scriptsearch.tsx as the ui implementation is just different between the two, but it was pretty straightforward to extract script card info -> card contents -- I looked at arcade.makecode.com/v1.5 and it doesn't show the thumbnail as the image or the "we're not endorsing this you know" warning, but those feel like pretty good additions to me
(it's also using the same |
|
I swapped it over to make it so loading share scripts uses the same |
webapp/src/extensionsBrowser.tsx
Outdated
| @@ -377,6 +428,21 @@ export const ExtensionsBrowser = (props: ExtensionsProps) => { | |||
| } | |||
| } | |||
|
|
|||
| function extensionMetaCard(scr: ExtensionMeta & EmptyCard, baseClass: string, ind: number) { | |||
There was a problem hiding this comment.
nit: make this a functional reach component
|
Once merged please port to microbit and arcade stable channels. |
* fix wrong gh extension being downloadexd * fix shareurl loading as extension * small cleanup thumbless share scripts * remove more specific types that were commented out * remove comment on delay * use addDepIfNoConflict to avoid duping loading logic * make ExtensionMetaCard a fc * actually just don't need className as it was just for key
* fix wrong gh extension being downloadexd * fix shareurl loading as extension * small cleanup thumbless share scripts * remove more specific types that were commented out * remove comment on delay * use addDepIfNoConflict to avoid duping loading logic * make ExtensionMetaCard a fc * actually just don't need className as it was just for key
* fix wrong gh extension being downloadexd * fix shareurl loading as extension * small cleanup thumbless share scripts * remove more specific types that were commented out * remove comment on delay * use addDepIfNoConflict to avoid duping loading logic * make ExtensionMetaCard a fc * actually just don't need className as it was just for key
* fix wrong gh extension being downloadexd * fix shareurl loading as extension * small cleanup thumbless share scripts * remove more specific types that were commented out * remove comment on delay * use addDepIfNoConflict to avoid duping loading logic * make ExtensionMetaCard a fc * actually just don't need className as it was just for key
* Extension search fixes (#9231) * fix wrong gh extension being downloadexd * fix shareurl loading as extension * small cleanup thumbless share scripts * remove more specific types that were commented out * remove comment on delay * use addDepIfNoConflict to avoid duping loading logic * make ExtensionMetaCard a fc * actually just don't need className as it was just for key * fix nested repos direct add (#9249)
* Extension search fixes (#9231) * fix wrong gh extension being downloadexd * fix shareurl loading as extension * small cleanup thumbless share scripts * remove more specific types that were commented out * remove comment on delay * use addDepIfNoConflict to avoid duping loading logic * make ExtensionMetaCard a fc * actually just don't need className as it was just for key * when no preferred extensions, don't show all approved exts (#9247) * when no preferred extensions, don't show all approved exts * use preferredexts instead of extToShow to fix clicking back * Fix minecraft hoc layout bug (#9243) * fix minecraft hoc height issue * simplify offset height calc for old tutorials * move conditional logic into conditional * also update editoroffset post setTutorialInstructionExpanded * fix nested repos direct add (#9249)
left a few todos spread around as I didn't want to go to poke around too much besides fixing the known regressions as this will probably be ported to arcade, microbit, maybe minecraft (I'm guessing content authors could be using the share script extensions to test at least?) ~
Here's a build to double check: https://arcade.makecode.com/app/5dc92e4c8357413a5065b97411a4157ffd9c89ec-0aa863d716