-
Notifications
You must be signed in to change notification settings - Fork 618
add Import as asset Pack to github extension zone #11080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds support for pxtJsonOptions (such as "Import as asset Pack") to the GitHub extension zone, making configuration toggles available in the GitHub UI that were previously only accessible in the project settings editor. The feature enables extension authors to configure project properties directly from the GitHub integration interface.
Changes:
- Added
togglePxtJsonOptionmethod toGithubComponentclass to handle checkbox toggle events - Integrated pxtJsonOptions rendering in the ExtensionZone component
- Imported Checkbox component for toggle UI
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
This toggle looks good to me. |
updateConfigAsync does not return truthy This reverts commit cf70adb.
|
@jwunderl Is it possible to make a pxtjson text field? And how can I access it in the editor to read the value? |
|
@THEb0nny only toggle switches are currently supported. What are you trying to do? |
|
@riknoll I'd like to have a text field where I can specify the folder name for uploading the project to ev3. By default, it's uploaded to the BrkProg_SAVE path. I changed this constant, and the editor loaded it into ev3 using a new path, creating a folder. I tried to do this, but I didn't understand how to access the field from the project's json.pxt in deploy.ts. As I understand it, I could do this even without a text field by specifying my property using the pxt.json text editor. But I don't know how to access the project field in deploy.ts. Can you help? |
|
@THEb0nny the compile result object passed into that function should have a fileSystem property that contains the entire source of the compiled program including pxt.json |
|
@riknoll I implemented it like this. But there is no pxt.json file... console out: pxt.json not found |
build https://arcade.makecode.com/app/3928b4381f0337f3cfdb490076b29faa86d52c1a-97e398c5f5
adds the target toggles from pxtjson to gitjson as well (which is only used for share as asset pack currently)

Could do a button that opens project settings instead, since description / other stuff going in there? Could go either way personally, toggle doesn't feel too out of place.
Does bump you down slightly the first time it's pressed since it immediately updates like this:
