Skip to content

propagate a query parameter for ai server changes #11070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jwunderl wants to merge 2 commits into
base: master
Choose a base branch
from
Open

propagate a query parameter for ai server changes #11070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
545b122
propagate a query parameter for ai server changes
jwunderl Jan 28, 2026
4e827d1
casting not needed
jwunderl Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions pxtlib/browserutils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1451,6 +1451,21 @@ namespace pxt.BrowserUtils {
return url;
}

export function getCopilotServerParam(): "ppe" | "prod" | undefined {
if (typeof window === "undefined") return undefined;
const query = pxt.Util.parseQueryString(window.location.search || "");
const value = (query["useCopilotServer"] || "").toLowerCase();
return value === "ppe" || value === "prod" ? value : undefined;
}

export function appendCopilotServerQueryParam(url: string): string {
const value = getCopilotServerParam();
if (!value) return url;
const params = new URLSearchParams();
Copy link
Contributor

@srietkerk srietkerk Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering for extra security if we should check if the user is logged in at this point? Like if there's no login, don't append the query param?

Copy link
Member Author

@jwunderl jwunderl Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any security for backend endpoints on the front end is fake; a malicious user will just curl or make the request themselves in the dev tools anyways. no harm in the query parameter existing as the back end is the one that determines whether it is a valid request or not.

(besides that all of our copilot integrations are gated on auth already)

params.set("useCopilotServer", value);
return appendUrlQueryParams(url, params);
}

export function legacyCopyText(element: HTMLInputElement | HTMLTextAreaElement) {
element.focus();
element.setSelectionRange(0, 9999);
Expand Down
2 changes: 1 addition & 1 deletion teachertool/src/services/backendRequests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export async function loadTestableCollectionFromDocsAsync<T>(fileNames: string[]
}

export async function askCopilotQuestionAsync(shareId: string, question: string): Promise<string | undefined> {
const url = `/api/copilot/question`;
const url = pxt.BrowserUtils.appendCopilotServerQueryParam(`/api/copilot/question`);

question = pxt.Util.cleanData(question);

Expand Down
4 changes: 2 additions & 2 deletions webapp/src/cloud.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,8 +697,8 @@ export async function aiErrorExplainRequest(
outputFormat: "tour_json" | "text",
locale: string
): Promise<string | undefined> {
const startUrl = `/api/copilot/startexplainerror`;
const statusUrl = `/api/copilot/explainerrorstatus`;
const startUrl = pxt.BrowserUtils.appendCopilotServerQueryParam(`/api/copilot/startexplainerror`);
const statusUrl = pxt.BrowserUtils.appendCopilotServerQueryParam(`/api/copilot/explainerrorstatus`);

const data = { lang, code, errors, target, outputFormat, locale };

Expand Down
Loading