Skip to content

lots of keyboard accessibility fixes for gridpicker#10845

Merged
riknoll merged 6 commits intomasterfrom
dev/riknoll/gridpicker-keyboard
Aug 25, 2025
Merged

lots of keyboard accessibility fixes for gridpicker#10845
riknoll merged 6 commits intomasterfrom
dev/riknoll/gridpicker-keyboard

Conversation

@riknoll
Copy link
Member

@riknoll riknoll commented Aug 21, 2025

fixes https://github.com/microsoft/pxt-minecraft/issues/2806

adds a bunch of fixes related to using the gridpicker with keyboard controls in minecraft:

  • pressing escape when the field editor is expanded no longer opens the simulator
  • fixes the focus indicator outline on shadow blocks with dropdown fields and labels, but no other editable inputs/fields (like the item block in the linked issue)
  • focus is now trapped in the gridpicker when either the searchbar or selection bar is present
  • the selected item is now actually visible when selecting using the keyboard arrows (uses the standard focus color)
  • tabbing out of the searchbar no longer resets the selected item
  • fixes keyboard nav when the items in the grid are filtered via the searchbar
  • the tooltip is now displayed underneath the selected item when using keyboard navigation

gridpicker-keyboard

@riknoll riknoll requested a review from a team August 21, 2025 00:24
@riknoll riknoll merged commit cec635b into master Aug 25, 2025
19 checks passed
@riknoll riknoll deleted the dev/riknoll/gridpicker-keyboard branch August 25, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants