-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-layout of blocks should position the start block at the top-left. #4194
Labels
Comments
Creating PR for this bug-fix. |
Sweet.
…________________________________
From: Sam El-Husseini <notifications@github.com>
Sent: Monday, April 23, 2018 8:24:26 AM
To: Microsoft/pxt
Cc: Matthew Tebbs; Assign
Subject: Re: [Microsoft/pxt] Auto-layout of blocks should position the start block at the top-left. (#4194)
Assigned #4194<#4194> to @matthewtebbs<https://github.com/matthewtebbs>.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub<#4194 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABW9h-wN1bAkNUjVwjsnIZ6wHPzAi4cYks5trfIqgaJpZM4TfCDg>.
|
Why was this closed?
…________________________________
From: Abhijith Chatra <notifications@github.com>
Sent: Tuesday, May 15, 2018 4:43:47 PM
To: Microsoft/pxt
Cc: Matthew Tebbs; Mention
Subject: Re: [Microsoft/pxt] Auto-layout of blocks should position the start block at the top-left. (#4194)
Closed #4194<#4194>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#4194 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABW9h1896tqwG5pMG-wdwVAL98-QtDJZks5ty2gzgaJpZM4TfCDg>.
|
I assumed you made the pr as per comments. Reopening |
Hi! I have a project for a software methodology class to contribute to an open source repo and I am very interested in this project. Could I be assigned to this issue? |
@jlbrewe feel free to pick this up. Make sure this issue still reproduces. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The code actually checks for whether the
start
block is at top-left and if other blocks are not to decide if it should re-layout.I suspect the current code will auto-layout my hand-positioned blocks if
start
is not top-left which is not expected.The text was updated successfully, but these errors were encountered: