Skip to content

Minor fix in top positioning of the field number picker #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

samelhusseini
Copy link
Contributor

@samelhusseini samelhusseini commented Oct 23, 2018

Noticed that the recent fix for the field number (#125) wasn't properly positioning the picker when positioned above the field, see screenshots. Following @rachel-fenichel fix in scratchfoundation/scratch-blocks#1741

Before:
screen shot 2018-10-23 at 9 05 51 am

After:
screen shot 2018-10-23 at 9 05 39 am

@samelhusseini samelhusseini requested a review from riknoll October 23, 2018 16:08
@samelhusseini samelhusseini merged commit f1b89c9 into develop Oct 23, 2018
@samelhusseini samelhusseini deleted the fieldnumberpadposition branch October 23, 2018 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants