Skip to content

Conversation

@bb-froggy
Copy link
Contributor

This avoids an error message when PSScriptAnalyzer is already there (the default in current GitHub Actions using ubuntu-latest).

Also changed the test message to a more production-compatible one.

@fflaten
Copy link

fflaten commented Jul 13, 2022

@bb-froggy Want to extend this to ConvertoToSARIF also while at it? 🙂

@bb-froggy
Copy link
Contributor Author

Good idea, I have added the code for ConvertToSARIF and tested that it works in my environments.

@fflaten
Copy link

fflaten commented Jul 14, 2022

Thanks. Trying to reduce CI time by caching these, so the always force install is not great.

Let's hope this gets merged at some point 🙂

@eizedev
Copy link

eizedev commented Aug 12, 2022

Hi, when do you think this will be merged? Currently I am using the commit from @bb-froggy for ubuntu-latest:

Run microsoft/psscriptanalyzer-action@452b6222221f82be3420596e9bd148a7b2bb5bb8
Run $analyzerModule = Get-Module -ListAvailable -Name PSScriptAnalyzer
Modules installed, now running tests.

@aaronparker
Copy link

aaronparker commented Aug 14, 2022

Any chance this is going to be merged? Consistently getting the following error in my workflow

Run microsoft/psscriptanalyzer-action@2044ae068e37d0161fa2127de04c19633882f061
Run Install-Module -Name PSScriptAnalyzer -Force
WARNING: The version '1.20.0' of module 'PSScriptAnalyzer' is currently in use. Retry the operation after closing the applications.

@fflaten
Copy link

fflaten commented Aug 15, 2022

@JamesWTruher Got a tip that you are a maintainer of this repo. Is anyone watching this and ConvertToSARIF? Would it be possible to get the pending PRs merged?

Btw. this repo also contains some template-content in README (project-section) and SUPPORT.

@JamesWTruher
Copy link

@fflaten I am not the maintainer of this repo

@fflaten
Copy link

fflaten commented Aug 22, 2022

@fflaten I am not the maintainer of this repo

Oh, bad tip then. Are you by any chance able to see who is or know who might be able to assist?

@bb-froggy
Copy link
Contributor Author

Maybe @A-Katopodis ? Are you a maintainer?

@fflaten
Copy link

fflaten commented Sep 13, 2022

Are you able to get someone's attention to these repos @SydneyhSmith ? 😇

Also, should they be part of Powershell-org like PSScriptAnalyzer itself?

@A-Katopodis
Copy link
Contributor

Hi folks,

Sorry for the delay. I did take a look and I will merge and create a PR to update the default Github actions as well. Thanks!

@A-Katopodis A-Katopodis merged commit a14f26f into microsoft:main Sep 13, 2022
@fflaten
Copy link

fflaten commented Sep 13, 2022

Thanks @A-Katopodis. I appreciate it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants