Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some macros #136

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Conversation

mingxwa
Copy link
Collaborator

@mingxwa mingxwa commented Jul 25, 2024

Changes

  • Replaced macro PRO_DEF_OPERATOR_DISPATCH, PRO_DEF_LHS_OPERATOR_DISPATCH and PRO_DEF_RHS_OPERATOR_DISPATCH with class template pro::operator_dispatch<fixed-string Sign, bool Rhs = false>.
  • Replaced macro PRO_DEF_CONVERSION_DISPATCH with class template pro::conversion_dispatch<class T, bool Expl = true>.
  • Removed the 4th parameter in macro PRO_DEF_MEM_DISPATCH and PRO_DEF_FREE_DISPATCH to define a default implementation.
  • Added another macro PRO_DEF_WEAK_DISPATCH to explicitly extend an existing dispatch type with a default implementation.
  • Updated unit tests and README accordingly.

@mingxwa mingxwa self-assigned this Jul 25, 2024
Copy link
Collaborator

@tian-lt tian-lt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mingxwa mingxwa merged commit 09fbd80 into microsoft:main Jul 29, 2024
4 checks passed
@mingxwa mingxwa deleted the user/mingxwa/remove-macros branch July 29, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants