Disable image parsing #274
Open
+139
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ✨ Add missing 'strict' and 'options' fields to TemplateProperty for better template configuration - 🔧 Implement logic to disable image parsing based on template options in PromptyChatParser - ✅ Add tests to verify image parsing behaviour when disabled and enabled
- 🐛 Add handling for optional inputs without defaults - 🔍 Raise error for missing required input properties - 📜 Refactor code for clarity and maintainability
Author
|
@sethjuarez - please review. |
Author
|
@sethjuarez - is this project still being maintained? If not, then I will have to remove it from my applications. There hasn't been much activity lately... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the Prompty runtime and documentation, focusing on enhanced configurability for markdown image parsing, improved input validation, and expanded test coverage. The most significant changes are the addition of a new configuration option to disable automatic image parsing in prompts, updates to the documentation to reflect this feature, and the introduction of comprehensive tests to ensure correct parser behavior.
Image Parsing Configuration
disable_image_parsingoption in theTemplateProperty.optionsdictionary. When enabled, the parser returns content as-is without processing images. (runtime/prompty/prompty/parsers.py,runtime/prompty/prompty/core.py) [1] [2]README.md) to describe the newdisable_image_parsingoption, including usage examples and scenarios where it is beneficial. (runtime/prompty/README.md)Testing and Validation
runtime/prompty/tests/test_parser.py)runtime/prompty/prompty/__init__.py)Documentation and Usability
README.mdto cover configuration options, CLI usage, available invokers, tracing, and contribution guidelines. (runtime/prompty/README.md) [1] [2] [3] [4] [5] [6]