[experiment] Verify command injection when starting experiments asynchronously #3685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalala123123
had a problem deploying
to
internal
GitHub Actions
Failure
lalala123123
had a problem deploying
to
internal
GitHub Actions
Failure
lalala123123
had a problem deploying
to
internal
GitHub Actions
Failure
lalala123123
had a problem deploying
to
internal
GitHub Actions
Failure
wangchao1230
previously approved these changes
Aug 23, 2024
promptflow SDK CLI Azure E2E Test Result zhrua/fix_inject 4 files 4 suites 4m 19s ⏱️ Results for commit 4132d42. ♻️ This comment has been updated with latest results. |
SDK CLI Global Config Test Result zhrua/fix_inject6 tests 6 ✅ 1m 20s ⏱️ Results for commit 4132d42. ♻️ This comment has been updated with latest results. |
Executor Unit Test Result zhrua/fix_inject798 tests 798 ✅ 3m 41s ⏱️ Results for commit 4132d42. ♻️ This comment has been updated with latest results. |
Executor E2E Test Result zhrua/fix_inject246 tests 240 ✅ 5m 5s ⏱️ Results for commit 4132d42. ♻️ This comment has been updated with latest results. |
SDK CLI Test Result zhrua/fix_inject 4 files 4 suites 1h 5m 37s ⏱️ Results for commit 4132d42. |
wangchao1230
approved these changes
Aug 23, 2024
zhengfeiwang
approved these changes
Aug 23, 2024
singankit
pushed a commit
that referenced
this pull request
Sep 18, 2024
…hronously (#3685) # Description Added command parameter detection before executing commands to avoid risky characters. # All Promptflow Contribution checklist: - [ ] **The pull request does not introduce [breaking changes].** - [ ] **CHANGELOG is updated for new features, bug fixes or other significant changes.** - [ ] **I have read the [contribution guidelines](https://github.com/microsoft/promptflow/blob/main/CONTRIBUTING.md).** - [ ] **I confirm that all new dependencies are compatible with the MIT license.** - [ ] **Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: [suggested workflow](../CONTRIBUTING.md#suggested-workflow).** ## General Guidelines and Best Practices - [ ] Title of the pull request is clear and informative. - [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### Testing Guidelines - [ ] Pull request includes test coverage for the included changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added command parameter detection before executing commands to avoid risky characters.
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines