Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(create-playwright): add option to add examples #8963

Merged
merged 5 commits into from
Oct 21, 2021
Merged

feat(create-playwright): add option to add examples #8963

merged 5 commits into from
Oct 21, 2021

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Sep 16, 2021 •
edited
Loading

Fixes #8892

@mxschmitt mxschmitt force-pushed the create-playwright-examples branch 2 times, most recently from 523fd40 to a416ee1 Compare September 16, 2021 14:11
@mxschmitt mxschmitt marked this pull request as ready for review September 16, 2021 14:41
dgozman
dgozman reviewed Sep 16, 2021
View reviewed changes
packages/create-playwright/assets/playwright.config.js Outdated Show resolved Hide resolved
packages/create-playwright/assets/playwright.config.js Outdated Show resolved Hide resolved
packages/create-playwright/assets/examples/2-element-selectors.spec.ts Outdated Show resolved Hide resolved
packages/create-playwright/assets/examples/2-element-selectors.spec.ts Outdated Show resolved Hide resolved
packages/create-playwright/assets/examples/4-pom.spec.ts Outdated Show resolved Hide resolved
packages/create-playwright/assets/examples/4-pom.spec.ts Outdated Show resolved Hide resolved
packages/create-playwright/assets/examples/5-file-uploads.spec.ts Outdated Show resolved Hide resolved
packages/create-playwright/assets/examples/7-mock-network-requests.spec.ts Outdated Show resolved Hide resolved
@mxschmitt mxschmitt force-pushed the create-playwright-examples branch 3 times, most recently from 5079e90 to 1e73ea4 Compare September 19, 2021 20:32
@mxschmitt mxschmitt changed the title feat(create-playwright): added more examples feat(create-playwright): add option to add examples Sep 19, 2021
@mxschmitt mxschmitt force-pushed the create-playwright-examples branch 3 times, most recently from 0ae5023 to fb5b408 Compare September 20, 2021 07:54
@mxschmitt mxschmitt requested a review from dgozman September 20, 2021 07:59
dgozman
dgozman reviewed Sep 20, 2021
View reviewed changes
packages/create-playwright/assets/examples/2-element-selectors.spec.ts Outdated Show resolved Hide resolved
packages/create-playwright/assets/examples/2-element-selectors.spec.ts Outdated Show resolved Hide resolved
packages/create-playwright/assets/examples/3-assertions.spec.ts Outdated Show resolved Hide resolved
packages/create-playwright/assets/examples/3-assertions.spec.ts Outdated Show resolved Hide resolved
packages/create-playwright/assets/examples/4-pom.spec.ts Outdated Show resolved Hide resolved
packages/create-playwright/assets/examples/9-cookies.spec.ts Outdated Show resolved Hide resolved
packages/create-playwright/assets/examples/9-cookies.spec.ts Outdated Show resolved Hide resolved
packages/create-playwright/assets/examples/playwright.config.ts Outdated Show resolved Hide resolved
packages/create-playwright/assets/examples/server/index.js Outdated Show resolved Hide resolved
packages/create-playwright/src/index.ts Outdated Show resolved Hide resolved
@mxschmitt mxschmitt force-pushed the create-playwright-examples branch 3 times, most recently from d48f106 to 1804836 Compare October 15, 2021 14:23
@mxschmitt mxschmitt mentioned this pull request Oct 15, 2021
Merged
@mxschmitt mxschmitt force-pushed the create-playwright-examples branch 2 times, most recently from 91370b6 to d1026bf Compare October 15, 2021 15:08
@mxschmitt mxschmitt force-pushed the create-playwright-examples branch 2 times, most recently from a9aec5d to add9576 Compare October 19, 2021 12:01
@mxschmitt mxschmitt force-pushed the create-playwright-examples branch from add9576 to 4bcf4cc Compare October 19, 2021 12:10
@mxschmitt mxschmitt requested a review from dgozman October 19, 2021 15:29
dgozman
dgozman reviewed Oct 20, 2021
View reviewed changes
packages/create-playwright/assets/examples/0-server/index.js Outdated Show resolved Hide resolved
packages/create-playwright/assets/examples/5-pom/1-pom.spec.ts Outdated Show resolved Hide resolved
packages/create-playwright/assets/examples/5-pom/2-pom-fixtures.spec.ts Outdated Show resolved Hide resolved
packages/create-playwright/assets/examples/5-pom/todo.pom.ts Outdated Show resolved Hide resolved
packages/create-playwright/assets/examples/5-pom/2-pom-fixtures.ts Outdated Show resolved Hide resolved
packages/create-playwright/assets/examples/1-getting-started.spec.ts Show resolved Hide resolved
packages/create-playwright/assets/examples/2-actions.spec.ts Outdated Show resolved Hide resolved
packages/create-playwright/assets/examples/2-actions.spec.ts Show resolved Hide resolved
packages/create-playwright/assets/examples/5-networking.spec.ts Outdated Show resolved Hide resolved
packages/create-playwright/assets/examples/5-networking.spec.ts Outdated Show resolved Hide resolved
@mxschmitt mxschmitt force-pushed the create-playwright-examples branch from 0f04fc1 to 6aa61e2 Compare October 20, 2021 08:59
@mxschmitt mxschmitt force-pushed the create-playwright-examples branch from 6aa61e2 to 1e9fc93 Compare October 20, 2021 09:15
@mxschmitt mxschmitt requested a review from dgozman October 21, 2021 14:20
dgozman
dgozman approved these changes Oct 21, 2021
View reviewed changes
packages/create-playwright/assets/examples/2-actions.spec.ts Outdated Show resolved Hide resolved
packages/create-playwright/assets/examples/2-actions.spec.ts Outdated
await inputBox.fill('Learn Playwright');
await inputBox.press('Enter');
await expect(todoList).toHaveText('Learn Playwright');
await page.locator('.filters >> text=Completed').click();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps just text=Completed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strict mode would kick in, there is also an element called "All Completed"

packages/create-playwright/assets/examples/4-file-uploads.spec.ts Outdated Show resolved Hide resolved
packages/create-playwright/assets/examples/pom/pom-with-fixtures.spec.ts Show resolved Hide resolved
packages/create-playwright/assets/examples/pom/todoPage.pom.ts Outdated Show resolved Hide resolved
packages/create-playwright/assets/examples/server/assets/index.html Outdated
@@ -0,0 +1,3 @@
<object data="header.html" style="width: 100%; height: 200px;">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why object? I guess I am missing something.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to iframe instead, reason is so that we have a unified header across all the pages.

@mxschmitt mxschmitt merged commit dd5364e into microsoft:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[internal] create-playwright release blockers
2 participants
@mxschmitt @dgozman