fix(tracing): do not stall on dialogs #7059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
approved these changes
Jun 11, 2021
| await page.goto(server.EMPTY_PAGE); | ||
|
|
||
| page.on('dialog', async dialog => { | ||
| await dialog.accept(); |
There was a problem hiding this comment.
Do we have to catch this promise and await it? I am worried that dialog.accept will race with context.close and throw an unhandled promise rejection.
There was a problem hiding this comment.
I believe we are ok since the following call to confirm is blocking and is serialized with the accept ack.
JoelEinbinder
approved these changes
Jun 11, 2021
Co-authored-by: Joel Einbinder <joel.einbinder@gmail.com>
aslushnikov
pushed a commit
to aslushnikov/playwright
that referenced
this pull request
Jun 11, 2021
Cherry-Pick microsoft#7059 SHA cbce7cb Fixes microsoft#7048
aslushnikov
added a commit
that referenced
this pull request
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7048