fix(test runner): remove folio/jest namespaces in expect matchers #6930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
approved these changes
Jun 7, 2021
| interface Matchers<R> { | ||
| toBeWithinRange(a: number, b: number): R; | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| To import expect matching libraries like [jest-extended](https://github.com/jest-community/jest-extended#installation) you can import it from your `global.d.ts`: |
There was a problem hiding this comment.
Wouldn't something like that work for users then? (move extending from jest from us to the use-space). Then the native expect-extend imports should work out of the box.
declare namespace PlaywrightTest {
interface Matchers<R> extends jest.Matchers<R> {
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll be able to bring jest namespace back if/when needed.