Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(webkit): bump to 1492 #6887

Merged
merged 1 commit into from
Jun 3, 2021
Merged

feat(webkit): bump to 1492 #6887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion browsers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
},
{
"name": "webkit",
"revision": "1490",
"revision": "1492",
"installByDefault": true,
"revisionOverrides": {
"mac10.14": "1444"
Expand Down
8 changes: 2 additions & 6 deletions tests/browsercontext-locale.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,19 +57,15 @@ it('should format date', async ({browser, server, browserName}) => {
const context = await browser.newContext({ locale: 'en-US', timezoneId: 'America/Los_Angeles' });
const page = await context.newPage();
await page.goto(server.EMPTY_PAGE);
const formatted = browserName === 'webkit' ?
'Sat Nov 19 2016 10:12:34 GMT-0800' :
'Sat Nov 19 2016 10:12:34 GMT-0800 (Pacific Standard Time)';
const formatted = 'Sat Nov 19 2016 10:12:34 GMT-0800 (Pacific Standard Time)';
expect(await page.evaluate(() => new Date(1479579154987).toString())).toBe(formatted);
await context.close();
}
{
const context = await browser.newContext({ locale: 'de-DE', timezoneId: 'Europe/Berlin' });
const page = await context.newPage();
await page.goto(server.EMPTY_PAGE);
const formatted = browserName === 'webkit' ?
'Sat Nov 19 2016 19:12:34 GMT+0100' :
'Sat Nov 19 2016 19:12:34 GMT+0100 (Mitteleuropäische Normalzeit)';
const formatted = 'Sat Nov 19 2016 19:12:34 GMT+0100 (Mitteleuropäische Normalzeit)';
expect(await page.evaluate(() => new Date(1479579154987).toString())).toBe(formatted);
await context.close();
}
Expand Down
16 changes: 4 additions & 12 deletions tests/browsercontext-timezone-id.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,33 +22,25 @@ it('should work', async ({ browser, browserName }) => {
{
const context = await browser.newContext({ locale: 'en-US', timezoneId: 'America/Jamaica' });
const page = await context.newPage();
expect(await page.evaluate(func)).toBe(browserName === 'webkit' ?
'Sat Nov 19 2016 13:12:34 GMT-0500' :
'Sat Nov 19 2016 13:12:34 GMT-0500 (Eastern Standard Time)');
expect(await page.evaluate(func)).toBe('Sat Nov 19 2016 13:12:34 GMT-0500 (Eastern Standard Time)');
await context.close();
}
{
const context = await browser.newContext({ locale: 'en-US', timezoneId: 'Pacific/Honolulu' });
const page = await context.newPage();
expect(await page.evaluate(func)).toBe(browserName === 'webkit' ?
'Sat Nov 19 2016 08:12:34 GMT-1000' :
'Sat Nov 19 2016 08:12:34 GMT-1000 (Hawaii-Aleutian Standard Time)');
expect(await page.evaluate(func)).toBe('Sat Nov 19 2016 08:12:34 GMT-1000 (Hawaii-Aleutian Standard Time)');
await context.close();
}
{
const context = await browser.newContext({ locale: 'en-US', timezoneId: 'America/Buenos_Aires' });
const page = await context.newPage();
expect(await page.evaluate(func)).toBe(browserName === 'webkit' ?
'Sat Nov 19 2016 15:12:34 GMT-0300' :
'Sat Nov 19 2016 15:12:34 GMT-0300 (Argentina Standard Time)');
expect(await page.evaluate(func)).toBe('Sat Nov 19 2016 15:12:34 GMT-0300 (Argentina Standard Time)');
await context.close();
}
{
const context = await browser.newContext({ locale: 'en-US', timezoneId: 'Europe/Berlin' });
const page = await context.newPage();
expect(await page.evaluate(func)).toBe(browserName === 'webkit' ?
'Sat Nov 19 2016 19:12:34 GMT+0100' :
'Sat Nov 19 2016 19:12:34 GMT+0100 (Central European Standard Time)');
expect(await page.evaluate(func)).toBe('Sat Nov 19 2016 19:12:34 GMT+0100 (Central European Standard Time)');
await context.close();
}
});
Expand Down
4 changes: 1 addition & 3 deletions tests/defaultbrowsercontext-2.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,7 @@ it('should support reducedMotion option', async ({launchPersistent}) => {

it('should support timezoneId option', async ({launchPersistent, browserName}) => {
const {page} = await launchPersistent({locale: 'en-US', timezoneId: 'America/Jamaica'});
expect(await page.evaluate(() => new Date(1479579154987).toString())).toBe(browserName === 'webkit' ?
'Sat Nov 19 2016 13:12:34 GMT-0500' :
'Sat Nov 19 2016 13:12:34 GMT-0500 (Eastern Standard Time)');
expect(await page.evaluate(() => new Date(1479579154987).toString())).toBe('Sat Nov 19 2016 13:12:34 GMT-0500 (Eastern Standard Time)');
});

it('should support locale option', async ({launchPersistent}) => {
Expand Down