chore: do not use a subshell hack when using XVFB #6884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
reviewed
Jun 3, 2021
| # XVFB-RUN merges both STDOUT and STDERR, whereas we need only STDERR | ||
| # Wrap `npm run` in a subshell to redirect STDERR to file. | ||
| - run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- bash -c "npm run test -- --project=${{ matrix.browser }}" | ||
| - run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run test -- --project=${{ matrix.browser }} |
There was a problem hiding this comment.
I locally run the tests without --auto-servernum --server-args="-screen 0 1280x960x24 also in the Python repo we don't have it. Can we remove it?
There was a problem hiding this comment.
The --auto-servernum is a general good practice; this sets up isolated x displays for different commands. In our case we never have a second consumer for xvfb, but I'd still keep it.
The screen configuration was added at f0fcdc8 and I don't think anything has changed with that regard. I'd keep it as-is too.
mxschmitt
approved these changes
Jun 3, 2021
This was originally introduced in 9caa61a. However, we no longer save process STDERR.
aslushnikov
force-pushed
the
cleanup-xvfb-launching-on-gha
branch
from
5cf5b13
to
869b57d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally introduced in 9caa61a.
However, we no longer save process STDERR.