test(chromium): add failing test for connecting to a browser with pages #6502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
approved these changes
May 11, 2021
aslushnikov
pushed a commit
to aslushnikov/playwright
that referenced
this pull request
May 17, 2021
This cherry-picks two PRs: - PR microsoft#6502 SHA 2ea465b - PR microsoft#6511 SHA 3bded35
aslushnikov
added a commit
that referenced
this pull request
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by microsoft/playwright-python#679
It looks like Target.setAutoAttach doesn't wait for all current pages
to be attached.
Waiting for 500ms after creating the browser does correctly report
all pages.