devops: re-use firefox checkout for firefox-stable #6410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every patch to Firefox should also go to firefox-stable. This patch starts re-using Firefox-beta checkout for firefox-stable, making possible to easily rebaseline work atop of firefox-stable. With this patch, working on a patch in Firefox is a 2-step process: 1. work on a patch against Firefox-Beta 2. rebaseline your work atop of Firefox-Stable Working on Firefox-Beta is as usual: - setup an up-to-date firefox checkout: ```sh $ ./browser_patches/prepare_checkout.sh firefox ``` - create a new branch for your firefox work off `playwright-build`: ```sh $ cd ./browser_patches/firefox/checkout $ git checkout -b my-feature ``` - once work is done, export your branch: ```sh $ ./browser_patches/export.sh firefox ``` Rebaselining your work for Firefox-Stable takes advantage of a single checkout: - prepare a firefox-stable checkout: ```sh $ ./browser_patches/prepare_checkout.sh ff-stable ``` - rebaseline your feature branch atop of stable: ```sh $ cd ./browser_patches/firefox/checkout $ git checkout my-feature $ git rebase -i playwright-build ``` - make sure firefox-stable compiles: ```sh $ ./browser_patches/firefox-stable/build.sh ``` - export firefox-stable: ```sh $ ./browser_patches/export.sh ff-stable ```
yury-s
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every patch to Firefox should also go to firefox-stable. This patch
starts re-using Firefox-beta checkout for firefox-stable, making
possible to easily rebaseline work atop of firefox-stable.
With this patch, working on a patch in Firefox is a 2-step
process:
Working on Firefox-Beta is as usual:
playwright-build:$ cd ./browser_patches/firefox/checkout $ git checkout -b my-featureRebaselining your work for Firefox-Stable takes advantage of a single
checkout:
$ cd ./browser_patches/firefox/checkout $ git checkout my-feature $ git rebase -i playwright-build