fix: break require cycle #6353
Merged
fix: break require cycle #6353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
approved these changes
Apr 28, 2021
We have `CRBrowserContext` that extends `BrowserContext`, and it sometimes fails beacause `BrowserContext` is undefined, depending on the require order. Below is the require cycle. ```log server/browserContext.ts server/supplements/recorderSupplement.ts server/supplements/recorder/recorderApp.ts server/playwright.ts server/android/android.ts server/chromium/crBrowser.ts server/browserContext.ts ``` Fixing this by using `require`.
dgozman
force-pushed
the
break-require-cycle
branch
from
cd83486
to
e8d0bad
Compare
pavelfeldman
added a commit
that referenced
this pull request
Apr 29, 2021
This reverts commit 0bcfa92. Inspector no longer opens.
pavelfeldman
added a commit
that referenced
this pull request
Apr 29, 2021
This reverts commit 17e966b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have
CRBrowserContextthat extendsBrowserContext, andit sometimes fails beacause
BrowserContextis undefined, dependingon the require order. Below is the require cycle.
Fixing this by using
require.