chore(tracing): fix some of the start/stop scenarios #6337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
force-pushed
the
start_stop_3
branch
from
c56ad94
to
a271dd0
Compare
dgozman
approved these changes
Apr 27, 2021
| @@ -432,10 +432,12 @@ export function frameSnapshotStreamer(snapshotStreamer: string, snapshotBinding: | |||
| }; | |||
|
|
|||
| let allOverridesAreRefs = true; | |||
| for (const sheet of this._allStyleSheetsWithUrlOverride) { | |||
| for (const sheet of this._staleStyleSheets) { | |||
There was a problem hiding this comment.
I think we need to send all stylesheets that ever had an override every time, even when they are not stale (in this case it will be a number ref). Otherwise, the renderer will use the non-modified resource for this snapshot, instead of the last modified one.
There was a problem hiding this comment.
I won't claim I understand this part, but I don't change behavior here. Maybe you can follow up?
| this._interval = interval; | ||
| if (interval) | ||
| this._streamSnapshot(); | ||
| const visitNode = (node: Node | ShadowRoot) => { |
There was a problem hiding this comment.
In theory, we can replace the cache with WeakMap and just clear it here. Up to you.
src/server/frames.ts
Outdated
| @@ -197,10 +198,11 @@ export class FrameManager { | |||
|
|
|||
| frame._onClearLifecycle(); | |||
| const navigationEvent: NavigationEvent = { url, name, newDocument: frame._currentDocument }; | |||
| frame.emit(Frame.Events.Navigation, navigationEvent); | |||
| this._page.frameNavigatedToNewDocument(frame); | |||
src/server/frames.ts
Outdated
| if (!initial) { | ||
| debugLogger.log('api', ` navigated to "${url}"`); | ||
| this._page.frameNavigatedToNewDocument(frame); | ||
| frame.emit(Frame.Events.Navigation, navigationEvent); |
pavelfeldman
force-pushed
the
start_stop_3
branch
from
a271dd0
to
6c9b308
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.