docs(consoleMessage): add missing console message comments #6320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kblok
changed the title
kblok
force-pushed
the
vGeneratred/document-console-text
branch
from
c52f004
to
778716e
Compare
mxschmitt
requested changes
Apr 26, 2021
kblok
force-pushed
the
vGeneratred/document-console-text
branch
from
778716e
to
7ea4e4f
Compare
mxschmitt
requested changes
Apr 26, 2021
Co-authored-by: Max Schmitt <max@schmitt.mx>
mxschmitt
approved these changes
Apr 26, 2021
docs/src/api/class-consolemessage.md
Outdated
| @@ -5,6 +5,25 @@ | |||
| ## method: ConsoleMessage.args | |||
| - returns: <[Array]<[JSHandle]>> | |||
|
|
|||
| List or arguments passed to a `console` function call. | |||
|
|
|||
| ```js | |||
There was a problem hiding this comment.
This js snippet feels very lonely without its Python, Java and C# friends.
There was a problem hiding this comment.
I found that I was about to replicate the docs from Page.console. Added a link to that. @yury-s might want to confirm a fix in the java docs.
I found this dotnet tool a few months ago https://github.com/SimonCropp/MarkdownSnippets. Although it's .NET only, the idea is straightforward. You code the code example on a compilable place such as a unit test. And the doc would point to that snippet. Then you have a process that would replace the snippet with that code.
Just for you to think about it.
kblok
force-pushed
the
vGeneratred/document-console-text
branch
from
efa8e48
to
00ffd9e
Compare
yury-s
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes microsoft/playwright-dotnet#1199