fix(codegen): do not commit last action on mouse move #6252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a slow page that does a lot of things before navigating upon click, it is common to move mouse away from the click point. Previously, we would commit the click action and record a `page.goto()` for the navigation. Now we attribute any signals, even after accidental mouse move, to the previous action, in the 5-seconds time window.
pavelfeldman
approved these changes
Apr 20, 2021
This was referenced May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a slow page that does a lot of things before navigating upon click, it is common to move mouse away from the click point.
Previously, we would commit the click action and record a
page.goto()for the navigation. Now we attribute any signals, even after accidental mouse move, to the previous action, in the 5-seconds time window.Drive-by: emit
changeevent upon script clear to immediately update the UI.References #6168.