fix: browser dependency validation #6227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
bugfix/host-dependencies-validation
branch
2 times, most recently
from
67005e3
to
f0a30c4
Compare
Channels come from apt or from the |
mxschmitt
force-pushed
the
bugfix/host-dependencies-validation
branch
2 times, most recently
from
b328f21
to
8d77591
Compare
pavelfeldman
approved these changes
Apr 19, 2021
aslushnikov
reviewed
Apr 19, 2021
src/utils/registry.ts
Outdated
| @@ -303,6 +303,10 @@ export class Registry { | |||
| return tokens ? path.join(browserDirectory, ...tokens) : undefined; | |||
| } | |||
|
|
|||
| exists(browserName: BrowserName): boolean { | |||
There was a problem hiding this comment.
this is equal to the shouldRetain method below - let's just use it.
As a side note, shouldRetain is a pretty vague name - could you please rename it to something like isSupportedBrowser(browserName)?
mxschmitt
force-pushed
the
bugfix/host-dependencies-validation
branch
from
8d77591
to
f42b6c4
Compare
mxschmitt
force-pushed
the
bugfix/host-dependencies-validation
branch
from
f42b6c4
to
4c2fc9d
Compare
mxschmitt
changed the title
aslushnikov
approved these changes
Apr 20, 2021
mxschmitt
force-pushed
the
bugfix/host-dependencies-validation
branch
from
4c2fc9d
to
23d1e8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring the logic which was broken since #5820
This means:
Fixes #6226