Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: skip click test based on the browser version #6127

Merged
merged 2 commits into from
Apr 8, 2021
Merged

chore: skip click test based on the browser version #6127

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9606f25
chore: skip click test based on the browser version
yury-s Apr 7, 2021
9e35ad3
Make lint happy
yury-s Apr 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/selectors-misc.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ it('should work for open shadow roots', async ({page, server}) => {
expect(await page.$$(`data-testid:light=foo`)).toEqual([]);
});

it('should click on links in shadow dom', async ({page, server, browserName, browserChannel}) => {
it.fixme(browserName === 'chromium' && !!browserChannel, 'Enable when crrev.com/864024 get to the stable channel');
it('should click on links in shadow dom', async ({page, server, browserName, browserVersion}) => {
it.fixme(browserName === 'chromium' && browserVersion.split('.')[0] < 91, 'Remove when crrev.com/864024 gets to the stable channel');
it.fixme(!!process.env.PW_ANDROID_TESTS);

await page.goto(server.PREFIX + '/shadow-dom-link.html');
Expand Down