Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(downloads): subscribe to download events in Browser domain instead of Page #6082

Merged
merged 3 commits into from
Jun 4, 2021

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Apr 5, 2021

@mxschmitt mxschmitt changed the title feat(downloads): subsribe to download events in Browser domain instea… feat(downloads): subscribe to download events in Browser domain instead of Page May 10, 2021
@yury-s yury-s marked this pull request as ready for review June 1, 2021 18:26
@yury-s yury-s added the CQ1 label Jun 1, 2021
src/server/chromium/crPage.ts Outdated Show resolved Hide resolved
@yury-s yury-s added CQ1 and removed CQ1 labels Jun 1, 2021
@yury-s yury-s merged commit a96491c into microsoft:master Jun 4, 2021
@yury-s yury-s deleted the download-new-page branch June 4, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG?] Download promises don't resolve when using Chromium instead of Firefox in headful mode
3 participants