-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set system default python3 to python3.8 #5892
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do the same in Docker.focal
@yury-s oh yeah, good call! |
utils/docker/Dockerfile.bionic
Outdated
@@ -129,7 +129,8 @@ RUN adduser pwuser | |||
|
|||
RUN apt-get update && apt-get install -y python3.8 python3-pip && \ | |||
update-alternatives --install /usr/bin/pip pip /usr/bin/pip3 1 && \ | |||
update-alternatives --install /usr/bin/python python /usr/bin/python3 1 | |||
update-alternatives --install /usr/bin/python python /usr/bin/python3 1 && \ | |||
update-alternatives --install /usr/bin/python3 python3 /usr/bin/python3.8 1 && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove trailing && \
utils/docker/Dockerfile.focal
Outdated
@@ -129,7 +129,8 @@ RUN adduser pwuser | |||
|
|||
RUN apt-get update && apt-get install -y python3.8 python3-pip && \ | |||
update-alternatives --install /usr/bin/pip pip /usr/bin/pip3 1 && \ | |||
update-alternatives --install /usr/bin/python python /usr/bin/python3 1 | |||
update-alternatives --install /usr/bin/python python /usr/bin/python3 1 && \ | |||
update-alternatives --install /usr/bin/python3 python3 /usr/bin/python3.8 1 && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove trailing && \
Sorted. Also this may be addressed faster by someone else anyway, I need to wait for our legal team to review the licence before I can sign the CLA. |
Take your time and let us know if there are problems preventing you from committing this change, I or someone else could do it before the next release (likely next week). |
👍 from legal, CLA signed. Thanks all. |
This fixes #5891.