Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set system default python3 to python3.8 #5892

Merged
merged 3 commits into from
Mar 22, 2021
Merged

Conversation

rsalmond
Copy link
Contributor

This fixes #5891.

Copy link
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do the same in Docker.focal

@ghost
Copy link

ghost commented Mar 19, 2021

CLA assistant check
All CLA requirements met.

@rsalmond
Copy link
Contributor Author

@yury-s oh yeah, good call!

@@ -129,7 +129,8 @@ RUN adduser pwuser

RUN apt-get update && apt-get install -y python3.8 python3-pip && \
update-alternatives --install /usr/bin/pip pip /usr/bin/pip3 1 && \
update-alternatives --install /usr/bin/python python /usr/bin/python3 1
update-alternatives --install /usr/bin/python python /usr/bin/python3 1 && \
update-alternatives --install /usr/bin/python3 python3 /usr/bin/python3.8 1 && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing && \

@@ -129,7 +129,8 @@ RUN adduser pwuser

RUN apt-get update && apt-get install -y python3.8 python3-pip && \
update-alternatives --install /usr/bin/pip pip /usr/bin/pip3 1 && \
update-alternatives --install /usr/bin/python python /usr/bin/python3 1
update-alternatives --install /usr/bin/python python /usr/bin/python3 1 && \
update-alternatives --install /usr/bin/python3 python3 /usr/bin/python3.8 1 && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing && \

@rsalmond
Copy link
Contributor Author

Sorted. Also this may be addressed faster by someone else anyway, I need to wait for our legal team to review the licence before I can sign the CLA.

@yury-s
Copy link
Member

yury-s commented Mar 19, 2021

Take your time and let us know if there are problems preventing you from committing this change, I or someone else could do it before the next release (likely next week).

@rsalmond
Copy link
Contributor Author

👍 from legal, CLA signed. Thanks all.

@yury-s yury-s merged commit 1bcbb15 into microsoft:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - official docker image cannot pip install python playwright
3 participants