chore(evaluate): respect signals when evaluating on handle #5847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Mar 16, 2021
pavelfeldman
changed the title
yury-s
reviewed
Mar 17, 2021
| it('should work with noWaitAfter: true', async ({page, server}) => { | ||
| server.setRoute('/empty.html', async () => {}); | ||
| await page.setContent(`<a href="${server.EMPTY_PAGE}">empty.html</a>`); | ||
| await page.setContent(`<a id="anchor" href="${server.EMPTY_PAGE}">empty.html</a>`); |
yury-s
approved these changes
Mar 17, 2021
| const frame = page.frame({ name: 'target' }); | ||
| await Promise.all([ | ||
| page.click('a').then(() => messages.push('click')), | ||
| page.waitForEvent('framenavigated').then(() => messages.push('navigated')), |
There was a problem hiding this comment.
can we have a test that checks that we don't wait for the frame navigation ?
There was a problem hiding this comment.
It might be tricky - we would need to simulate slow iframe navigation commit :/
YusukeIwaki
added a commit
to YusukeIwaki/playwright-ruby-client
that referenced
this pull request
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.