devops: start downloading webkit fork on Mac 10.14 #5837
Conversation
src/utils/registry.ts
Outdated
| @@ -203,7 +203,11 @@ export class Registry { | |||
|
|
|||
| constructor(packagePath: string) { | |||
| const browsersJSON = JSON.parse(fs.readFileSync(path.join(packagePath, 'browsers.json'), 'utf8')); | |||
| this._descriptors = browsersJSON['browsers']; | |||
| this._descriptors = browsersJSON['browsers'].map((obj: any) => ({ | |||
| name: obj.name, | |||
There was a problem hiding this comment.
This way browser path stays the same and there is no way for us to tell if webkit-1444 in the cache is legacy mac14 build or the one that works for all newer OSes (if e.g. somebody puts it in a bug report). I can also imagine scenario where people upgrade their mac from 14 to something newer and use legacy build because it has matching version in the registry. Considering all that, I'd rather we put them in separate directories in the client side cache as well. WDYT?
There was a problem hiding this comment.
I can also imagine scenario where people upgrade their mac from 14 to something newer and use legacy build because it has matching version in the registry.
@yury-s Good point!
| const name = obj.name; | ||
| const revisionOverride = (obj.revisionOverrides || {})[hostPlatform]; | ||
| const revision = revisionOverride || obj.revision; | ||
| const browserDirectory = revisionOverride ? `${name}-${hostPlatform}-special-${revision}` : `${name}-${revision}`; |
There was a problem hiding this comment.
do we really need 'special' in the name, maybe drop it?
There was a problem hiding this comment.
I want to make sure it stands out. Otherwise, the name webkit-mac10.14-1234 is not eye-catching in any way, given that I'm on mac10.14
aslushnikov
force-pushed
the
start-downloading-webkit-fork
branch
from
2f47d53
to
42d66bb
Compare
References #5833