chore: organize per-browser dependencies #5787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Mar 10, 2021
dgozman
reviewed
Mar 10, 2021
pavelfeldman
force-pushed
the
install_deps
branch
from
0c95fda
to
23d684c
Compare
mxschmitt
approved these changes
Mar 10, 2021
src/install/installDeps.ts
Outdated
| ...deps.webkit | ||
| ].join(' ')); | ||
|
|
||
| // - `ffmpeg`: For video playback in Firefox |
There was a problem hiding this comment.
let's maybe have a single apt-get install call?
There was a problem hiding this comment.
Sure, I can try doing this. I hope --no-install-recommends won't break things for ffmpeg.
pavelfeldman
force-pushed
the
install_deps
branch
2 times, most recently
from
57df900
to
39ce253
Compare
pavelfeldman
changed the title
pavelfeldman
commented
Mar 12, 2021
| .action(async function(browserType) { | ||
| try { | ||
| await installDeps(browserType); | ||
| } catch (e) { | ||
| console.log(`Failed to install browsers\n${e}`); |
There was a problem hiding this comment.
I'll fix the message
yury-s
reviewed
Mar 12, 2021
| - run: npm ci | ||
| - run: npm run build | ||
| - run: node lib/cli/cli install-deps ${{ matrix.browser }} chromium |
| - run: npm ci | ||
| - run: npm run build | ||
| - run: node lib/cli/cli install-deps ${{ matrix.browser }} chromium |
| - run: npm ci | ||
| - run: npm run build | ||
| - run: node lib/cli/cli install-deps ${{ matrix.browser }} chromium |
| @@ -297,16 +297,16 @@ const LIBRARY_TO_PACKAGE_NAME_UBUNTU_18_04: { [s: string]: string} = { | |||
| 'libglib-2.0.so.0': 'libglib2.0-0', | |||
| 'libgmodule-2.0.so.0': 'libglib2.0-0', | |||
| 'libgobject-2.0.so.0': 'libglib2.0-0', | |||
| 'libgstapp-1.0.so.0': 'libgstreamer-plugins-base1.0-0', | |||
| 'libgstaudio-1.0.so.0': 'libgstreamer-plugins-base1.0-0', | |||
| 'libgstapp-1.0.so.0': 'gstreamer1.0-plugins-base', | |||
There was a problem hiding this comment.
See the comment above:
// This list is generted with the following program:
// ./utils/linux-browser-dependencies/run.sh ubuntu:18.04
should this part of mapping go there?
pavelfeldman
force-pushed
the
install_deps
branch
from
39ce253
to
a88d2dc
Compare
dgozman
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.