feat(java): implement codegen #5692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
Mar 3, 2021
| @@ -265,6 +294,14 @@ await Task.WhenAll( | |||
| }); | |||
| await page.click('text=click me');`); | |||
|
|
|||
| expect(sources.get('<java>').text).toContain(` | |||
| // Click text=click me | |||
| page.onceDialog(dialog -> { | |||
There was a problem hiding this comment.
there are no once* methods in java
There was a problem hiding this comment.
There should be this one :)
pavelfeldman
force-pushed
the
java_codegen
branch
from
8aa32c6
to
ca43662
Compare
pavelfeldman
added a commit
that referenced
this pull request
Mar 4, 2021
This was referenced Mar 10, 2021
Merged
Merged
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.