Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include parsed .md spec into api.json #5662

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Mar 1, 2021

  • Add .spec to all classes/members to simplify generation of language-specific docs (such as javadoc).
  • Keeping .comment fields too to minimize changes on the python end for now.

Raw api.json size differs by 0.5Mb but zipped one grows by just 31Kb so should not be a problem.

-rw-rw-r-- 1 yurys yurys 681K Mar  1 12:16 api.json
-rw-rw-r-- 1 yurys yurys 1.1M Mar  1 12:15 api.json-both
-rw-rw-r-- 1 yurys yurys 121K Mar  1 12:17 b.zip
-rw-rw-r-- 1 yurys yurys  90K Mar  1 12:17 c.zip

@yury-s yury-s merged commit c390f39 into microsoft:master Mar 1, 2021
@yury-s yury-s deleted the spec-in-json branch March 1, 2021 21:00
yury-s added a commit to yury-s/playwright that referenced this pull request Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants