Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bindings): unflake TestBrowserContextExposeFunction.shouldWork in java #5532

Merged
merged 1 commit into from
Feb 20, 2021

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Feb 20, 2021

This fixes following test failure in java:

Error:  Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.073 s <<< FAILURE! - in com.microsoft.playwright.TestBrowserContextExposeFunction
Error:  com.microsoft.playwright.TestBrowserContextExposeFunction.shouldWork  Time elapsed: 0.224 s  <<< ERROR!
com.microsoft.playwright.PlaywrightException: 
Error {
  message='Evaluation failed: Invalid arguments: should be exactly one string.
  name='Error
  stack='Error: Evaluation failed: Invalid arguments: should be exactly one string.
    at CRExecutionContext.evaluateWithArguments (C:\Users\RUNNER~1\AppData\Local\Temp\playwright-java-9156795998977864695\package\lib\server\chromium\crExecutionContext.js:71:19)
    at async Object.evaluateExpression (C:\Users\RUNNER~1\AppData\Local\Temp\playwright-java-9156795998977864695\package\lib\server\javascript.js:171:16)
    at async FrameManager.waitForSignalsCreatedBy (C:\Users\RUNNER~1\AppData\Local\Temp\playwright-java-9156795998977864695\package\lib\server\frames.js:108:24)
    at async FrameExecutionContext.evaluateExpressionInternal (C:\Users\RUNNER~1\AppData\Local\Temp\playwright-java-9156795998977864695\package\lib\server\dom.js:59:16)
    at async Frame._evaluateExpression (C:\Users\RUNNER~1\AppData\Local\Temp\playwright-java-9156795998977864695\package\lib\server\frames.js:506:23)
    at async FrameDispatcher.evaluateExpression (C:\Users\RUNNER~1\AppData\Local\Temp\playwright-java-9156795998977864695\package\lib\dispatchers\frameDispatcher.js:57:62)
    at async DispatcherConnection.dispatch (C:\Users\RUNNER~1\AppData\Local\Temp\playwright-java-9156795998977864695\package\lib\dispatchers\dispatcher.js:178:28)
}
	at com.microsoft.playwright.TestBrowserContextExposeFunction.shouldWork(TestBrowserContextExposeFunction.java:53)

@yury-s yury-s merged commit 1e327d4 into microsoft:master Feb 20, 2021
@yury-s yury-s deleted the expose-binding-test branch February 20, 2021 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants