chore: move stackTrace helpers from isomorphic to utils - #41591
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Skn0tt
approved these changes
Jul 2, 2026
| let _coreDir: string | undefined; | ||
| let _boxedStackPrefixes: string[] = []; | ||
| let _showInternalStackFrames = false; | ||
| let _showInternalStackFrames: boolean | undefined; |
Member
There was a problem hiding this comment.
This seems to be not needed anymore - except for if we expect PWDEBUGIMPL being mutated during the process lifetime. But I don't see that in the codebase, so it's probably fine to remove.
- Move packages/isomorphic/stackTrace.ts to packages/utils and use path.sep directly instead of threading a pathSeparator argument. - Compute PWDEBUGIMPL lazily inside stackTrace.ts instead of pushing it in via setShowInternalStackFrames(). - Source the StackFrame type from @trace/trace so browser/isomorphic code no longer depends on the node-only utils module.
dgozman
force-pushed
the
move-stacktrace-to-utils
branch
from
July 2, 2026 13:36
6c18532 to
b7f6265
Compare
Contributor
Test results for "MCP"2 failed 7459 passed, 1132 skipped Merge workflow run. |
Contributor
Test results for "tests 1"1 flaky49488 passed, 1165 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/isomorphic/stackTrace.tstopackages/utilsand usepath.sepdirectly instead of threading apathSeparatorargument through the API.PWDEBUGIMPLlazily insidestackTrace.tsinstead of pushing it in viasetShowInternalStackFrames().StackFrametype from@trace/traceso browser/isomorphic code no longer depends on the node-only utils module.