fix(tracing): include source for tracing.group(location)#39307
fix(tracing): include source for tracing.group(location)#39307Skn0tt merged 3 commits intomicrosoft:mainfrom
Conversation
Skn0tt
force-pushed
the
fix-group-location
branch
from
830ae5b to
8933de4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| await this._channel.tracingGroup({ name, location: options.location }); | ||
| await this._wrapApiCall(async zone => { | ||
| if (options.location) | ||
| zone.frames.push({ file: options.location.file, line: options.location.line ?? 0, column: options.location.column ?? 0 }); |
There was a problem hiding this comment.
This looks scary, I hope we don't do anything like this in other places. If we want to fix it, we should pass the overriding location to the _wrapApiCall and use it in the API zone.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
||
| export class Tracing extends ChannelOwner<channels.TracingChannel> implements api.Tracing { | ||
| private _includeSources = false; | ||
| private _additionalSources = new Set<string>(); |
There was a problem hiding this comment.
We should clean it up in stop/stopChunk.
| - write | ||
| - append | ||
| includeSources: boolean | ||
| additionalSources: |
There was a problem hiding this comment.
Forgot to say - make this one optional please.
Test results for "MCP"6 failed 5036 passed, 171 skipped Merge workflow run. |
Test results for "tests 1"4 flaky38521 passed, 843 skipped Merge workflow run. |
3 participants
Closes #39302