Skip to content

chore: scope screencast to the web socket lifetime#39243

Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman:grid-2-ws
Feb 12, 2026
Merged

chore: scope screencast to the web socket lifetime#39243
pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman:grid-2-ws

Conversation

@pavelfeldman
Copy link
Member

No description provided.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

import { defineTool } from './tool';

const devtoolsStart = defineTool({
const devtoolsConnect = defineTool({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did it change?

@github-actions
Copy link
Contributor

Test results for "tests 1"

3 failed
❌ [playwright-test] › expect.spec.ts:697 › should not print timed out error message when test times out @macos-latest-node20
❌ [playwright-test] › test-step.spec.ts:190 › should not report nested after hooks @macos-latest-node20
❌ [playwright-test] › to-have-screenshot.spec.ts:1022 › should satisfy both maxDiffPixelRatio and maxDiffPixels @macos-latest-node20

3 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1082 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:981 › cli codegen › should record when manual popover with fullscreen backdrop is open `@webkit-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:812 › should update state on subsequent run `@macos-latest-node20`

38519 passed, 843 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "MCP"

1 failed
❌ [chromium] › mcp/tracing.spec.ts:21 › check that trace is saved with --save-trace @mcp-windows-latest

4791 passed, 135 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants