fix(trace): respect dark mode in blank snapshot#39207
Merged
Skn0tt merged 1 commit intomicrosoft:mainfrom Feb 10, 2026
Merged
Conversation
dgozman
approved these changes
Feb 10, 2026
| return text.replace(urlToEscapeRegex1, replacer).replace(urlToEscapeRegex2, replacer); | ||
| } | ||
|
|
||
| export const blankSnapshotUrl = 'data:text/html;base64,' + btoa(`<body></body><style>body { color-scheme: light dark; background: light-dark(white, #333) }</style>`); |
Contributor
There was a problem hiding this comment.
I wonder why base64 is needed here? Seems like a nice html snippet.
Member
Author
There was a problem hiding this comment.
because of the , in light-dark() - it truncated behind that. i was a little surprised.
Contributor
Test results for "tests 1"3 flaky38556 passed, 843 skipped Merge workflow run. |
Contributor
Test results for "MCP"1 failed 4765 passed, 135 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #39201
before:
after: