Skip to content

fix(msedge): fix local network permissions #39036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavelfeldman merged 1 commit into from
Jan 29, 2026
+19 −8
Merged

fix(msedge): fix local network permissions #39036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions packages/playwright-core/src/server/chromium/crBrowser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,13 +452,25 @@ export class CRBrowserContext extends BrowserContext<CREventsMap> {
['local-fonts', 'localFonts'],
['local-network-access', ['localNetworkAccess', 'localNetwork', 'loopbackNetwork']],
]);
const filtered = permissions.flatMap(permission => {
const protocolPermission = webPermissionToProtocol.get(permission);
if (!protocolPermission)
throw new Error('Unknown permission: ' + permission);
return typeof protocolPermission === 'string' ? [protocolPermission] : protocolPermission;
});
await this._browser._session.send('Browser.grantPermissions', { origin: origin === '*' ? undefined : origin, browserContextId: this._browserContextId, permissions: filtered });

const grantPermissions = async (mapping: Map<string, Protocol.Browser.PermissionType | Protocol.Browser.PermissionType[]>) => {
const filtered = permissions.flatMap(permission => {
const protocolPermission = mapping.get(permission);
if (!protocolPermission)
throw new Error('Unknown permission: ' + permission);
return typeof protocolPermission === 'string' ? [protocolPermission] : protocolPermission;
});
await this._browser._session.send('Browser.grantPermissions', { origin: origin === '*' ? undefined : origin, browserContextId: this._browserContextId, permissions: filtered });
};

try {
await grantPermissions(webPermissionToProtocol);
} catch (e) {
// Old stable browsers dislike the new permission name, so we use the fallback mapping.
const fallbackMapping = new Map(webPermissionToProtocol);
fallbackMapping.set('local-network-access', ['localNetworkAccess']);
await grantPermissions(fallbackMapping);
}
}

async doClearPermissions() {
Expand Down
1 change: 0 additions & 1 deletion tests/library/permissions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,6 @@ it('local network request is allowed from public origin', {
annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/37861' }
}, async ({ page, context, server, browserName, channel, browserMajorVersion }) => {
it.skip(browserName === 'webkit');
it.skip(channel?.startsWith('msedge'));
it.skip(browserName === 'chromium' && browserMajorVersion < 145, 'local-network-access permission support has changed between versions');

if (browserName === 'chromium')
Expand Down
Loading