Skip to content

feat(expect): toHaveCSS with object notation #38982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dgozman merged 1 commit into from
Jan 28, 2026
Merged

feat(expect): toHaveCSS with object notation #38982

dgozman merged 1 commit into from
Jan 28, 2026

Conversation

@dgozman
Copy link
Contributor

@dgozman dgozman commented Jan 27, 2026

Closes #35113.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@dgozman dgozman requested a review from Skn0tt January 27, 2026 11:12
Skn0tt
Skn0tt approved these changes Jan 27, 2026
View reviewed changes
packages/playwright-core/src/server/frames.ts
if (!missingReceived) {
const rendered = renderUnexpectedValue(options.expression, received);
if (rendered !== undefined)
progress.log(` unexpected value "${rendered}"`);
Copy link
Member

@Skn0tt Skn0tt Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious, why don't we log arrays/objects?

Copy link
Contributor Author

@dgozman dgozman Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They end up as [Object object]. We can probably work on making this better, but separately.

@dgozman dgozman force-pushed the feat-to-have-css-object branch from dc3234b to 215eac8 Compare January 27, 2026 19:25
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

Test results for "MCP"

8 failed
❌ [webkit] › mcp/cli.spec.ts:426 › session › session-stop named session @mcp-windows-latest
❌ [webkit] › mcp/cli.spec.ts:452 › session › session-delete @mcp-windows-latest
❌ [chromium] › mcp/cli.spec.ts:58 › core › click link @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:96 › core › hover @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:149 › core › dialog-accept @mcp-macos-15
❌ [chromium] › mcp/test-debug.spec.ts:48 › test_debug (pause/resume) @mcp-macos-15
❌ [chromium] › mcp/test-debug.spec.ts:167 › test_debug (pause/snapshot/resume) @mcp-macos-15
❌ [chromium] › mcp/video.spec.ts:43 › should work with { saveVideo } (isolated) @mcp-macos-15

3438 passed, 116 skipped

Merge workflow run.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

Test results for "tests 1"

3 flaky ⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:226 › cli codegen › should generate frame locators (4) `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/popup.spec.ts:258 › should not throw when click closes popup `@chromium-ubuntu-22.04-node22`
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:38 › should upload a folder `@webkit-ubuntu-22.04-node20`

34243 passed, 668 skipped

Merge workflow run.

@dgozman dgozman merged commit 750fc94 into microsoft:main Jan 28, 2026
29 of 32 checks passed
This was referenced Jan 28, 2026
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skn0tt Skn0tt Skn0tt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Add support to add assertion for css attributes of any element

2 participants

@dgozman @Skn0tt