Skip to content

test: remove tmp profiles to save space #38413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −3
Open

test: remove tmp profiles to save space #38413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/playwright/src/mcp/browser/browserContextFactory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,8 @@ class PersistentContextFactory implements BrowserContextFactory {
await browserContext.close().catch(() => {});
await afterClose();
this._userDataDirs.delete(userDataDir);
if (process.env.PWMCP_PROFILES_DIR_FOR_TEST && userDataDir.startsWith(process.env.PWMCP_PROFILES_DIR_FOR_TEST))
await fs.promises.rm(userDataDir, { recursive: true }).catch(logUnhandledError);
testDebug('close browser context complete (persistent)');
}

Expand Down
10 changes: 7 additions & 3 deletions tests/mcp/launch.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ test('executable path', async ({ startClient, server }) => {
});
});

test('persistent context', async ({ startClient, server }) => {
test('persistent context', async ({ startClient, server }, testInfo) => {
server.setContent('/', `
<body>
</body>
Expand All @@ -87,7 +87,9 @@ test('persistent context', async ({ startClient, server }) => {
</script>
`, 'text/html');

const { client } = await startClient();
const { client } = await startClient({
args: [`--user-data-dir=${testInfo.outputPath('user-data-dir')}`],
});
expect(await client.callTool({
name: 'browser_navigate',
arguments: { url: server.PREFIX },
Expand All @@ -101,7 +103,9 @@ test('persistent context', async ({ startClient, server }) => {
name: 'browser_close',
});

const { client: client2 } = await startClient();
const { client: client2 } = await startClient({
args: [`--user-data-dir=${testInfo.outputPath('user-data-dir')}`],
});
expect(await client2.callTool({
name: 'browser_navigate',
arguments: { url: server.PREFIX },
Expand Down