chore: allow capturing port in webServer stdio #38181
Merged
+97
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
Nov 11, 2025
| if (stderrWaitCollector !== undefined) { | ||
| stderrWaitCollector += data.toString(); | ||
| if (this._options.wait?.stderr?.test(stderrWaitCollector)) | ||
| const result = this._options.wait?.stderr?.exec(stderrWaitCollector); |
Contributor
There was a problem hiding this comment.
Set this._options.wait?.stderr.lastIndex = 0 to avoid surprises?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pavelfeldman
force-pushed
the
web_env
branch
from
2d7160d to
10ff573
Compare
Contributor
Test results for "MCP"1 failed 2639 passed, 116 skipped Merge workflow run. |
Contributor
Test results for "tests 1"5 flaky40254 passed, 787 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.