chore(bidi): fix intercepts for context.route() #38180
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current BiDi implementation for
context.route()adds the intercepts whenever a newPageis created and has 2 issues:Pages that were created before the routeThis PR adds intercepts for
context.route()at theBrowserContextlevel and uses thePagelevel intercepts only forpage.route().Fixes the following tests (some of which were intermittent and/or only failed locally):
tests/library/browsercontext-route.spec.ts:tests/library/popup.spec.ts:tests/library/unroute-behavior.spec.ts: