Skip to content

Conversation

@vincenzo-gasparo
Copy link
Contributor

Add exact parameter to toMatchAriaSnapshot to save raw data

Fixes #38074, references #38074.

Copy link
Contributor

@agg23 agg23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. We always ask that people file issues first so we can triage and decide whether or not a PR is warranted, but in this case we do think this is something worth implementing (and it's a trivial implementation).

Minor comments: just naming and supporting both overloads.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@vincenzo-gasparo
Copy link
Contributor Author

vincenzo-gasparo commented Nov 5, 2025

@agg23 I cannot manage to make this code to work:

[`property: TestConfig.updateSnapshots`]

It gives me this error:

Error: Undefined member reference: [`property: TestConfig.updateSnapshots`]

Can you give me some help?

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@agg23
Copy link
Contributor

agg23 commented Nov 10, 2025

I cannot manage to make this code to work:

[`property: TestConfig.updateSnapshots`]

It gives me this error:

Error: Undefined member reference: [`property: TestConfig.updateSnapshots`]

Can you give me some help?

@vincenzo-gasparo this is because TestConfig is a JavaScript only concept; the other language ports do not support it (no test runner). You should disable the docs for this new flag in the non-JS platforms by setting langs: js everywhere, including on the new update parameter.

@github-actions
Copy link
Contributor

Test results for "MCP"

2 flaky ⚠️ [chrome] › mcp/cdp.spec.ts:24 › cdp server `@mcp-windows-latest`
⚠️ [chrome] › mcp/cdp.spec.ts:35 › cdp server reuse tab `@mcp-windows-latest`

2586 passed, 116 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › update-aria-snapshot.spec.ts:750 › update-source-method › should update when option relaxed is specified @macos-latest-node18-2

5 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-page] › page/page-event-request.spec.ts:182 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node18`
⚠️ [installation tests] › playwright-should-work-with-relative-browsers-path.spec.ts:20 › playwright should work with relative home path `@package-installations-ubuntu-latest`
⚠️ [playwright-test] › ui-mode-test-attachments.spec.ts:81 › should contain string attachment `@windows-latest-node18-2`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:350 › should reveal errors in the sourcetab `@windows-latest-node18-2`

40242 passed, 787 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Add aria snapshot raw saving

3 participants