chore(aria): extract compareSnapshots #37987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test results for "MCP"2570 passed, 108 skipped Merge workflow run. |
Contributor
Test results for "tests 1"4 flaky47161 passed, 815 skipped Merge workflow run. |
| } else { | ||
| let previous = typeof previousChild !== 'string' ? previousChild : undefined; | ||
| if (child.ref) | ||
| previous = previousByRef.get(child.ref); |
Member
There was a problem hiding this comment.
The way I read it, I can reorder child nodes and it'll yield the truthy result, yet you have it tested. Why does it work?
| return aKeys.length === bKeys.length && aKeys.every(k => a.props[k] === b.props[k]); | ||
| } | ||
| // Returns whether ariaNode is the same as previousNode. | ||
| const visit = (ariaNode: AriaNode, previousNode: AriaNode | undefined): boolean => { |
Member
There was a problem hiding this comment.
I'm growing increasingly unsympathetic towards rendering via delta. I think we should have a simple code path that does a simple thing and a complex code path that does complex things. If we need helper functions for it, let's introduce them beforehand.
| const escapedKey = indent + '- ' + yamlEscapeKeyIfNeeded(key); | ||
| const inCursorPointer = renderCursorPointer && !!ariaNode.ref && hasPointerCursor(ariaNode); | ||
| const singleInlinedTextChild = getSingleInlinedTextChild(ariaNode); | ||
| // Replace the whole subtree with a single reference when possible. |
Member
There was a problem hiding this comment.
Is this a part of compareSnapshots?
pavelfeldman
approved these changes
Oct 24, 2025
agg23
added a commit
to agg23/playwright
that referenced
this pull request
Oct 27, 2025
This reverts commit 1a06851.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.