Skip to content

chore: unship context.setStorageState#37021

Merged
dgozman merged 1 commit intomicrosoft:mainfrom
dgozman:chore-unship-context-setstoragestate
Aug 13, 2025
Merged

chore: unship context.setStorageState#37021
dgozman merged 1 commit intomicrosoft:mainfrom
dgozman:chore-unship-context-setstoragestate

Conversation

@dgozman
Copy link
Contributor

@dgozman dgozman commented Aug 13, 2025

No actual usecases for now, postponing.

No actual usecases for now, postponing.
@dgozman dgozman requested a review from yury-s August 13, 2025 19:02
@github-actions
Copy link
Contributor

Test results for "tests 1"

2 failed
❌ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:​206:5 › mobile viewport › view scale should reset after navigation @webkit-ubuntu-22.04-node18
❌ [webkit-library] › library/multiclient.spec.ts:​350:1 › should avoid side effects upon disconnect @webkit-ubuntu-22.04-node18

32 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:​1079:7 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-page] › page/page-add-script-tag.spec.ts:​93:3 › should throw when added with content to the CSP page `@firefox-ubuntu-22.04-node18`
⚠️ [webkit-library] › library/browsercontext-device.spec.ts:​45:5 › device › should scroll to click `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:​82:3 › should click the button with offset with page scale `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:​105:3 › should return bounding box with page scale `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:​97:5 › mobile viewport › should fire orientationchange event `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:​124:5 › mobile viewport › respect meta viewport tag `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:​157:5 › mobile viewport › mouse should work with mobile viewports and cross process navigations `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-library] › library/defaultbrowsercontext-2.spec.ts:​28:3 › should work in persistent context `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-library] › library/screenshot.spec.ts:​44:14 › page screenshot › should work with a mobile viewport `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-library] › library/screenshot.spec.ts:​55:14 › page screenshot › should work with a mobile viewport and clip `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-library] › library/screenshot.spec.ts:​205:14 › element screenshot › element screenshot should work with a mobile viewport `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-library] › library/video.spec.ts:​475:5 › screencast › should scale frames down to the requested size `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-page] › page/elementhandle-bounding-box.spec.ts:​30:3 › should handle nested frames `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-page] › page/elementhandle-screenshot.spec.ts:​27:5 › element screenshot › should work `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-page] › page/elementhandle-screenshot.spec.ts:​231:5 › element screenshot › should wait for element to stop moving `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-page] › page/expect-matcher-result.spec.ts:​302:5 › toHaveScreenshot should populate matcherResult `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-page] › page/locator-misc-2.spec.ts:​96:3 › should take screenshot `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-page] › page/page-add-locator-handler.spec.ts:​184:5 › should work with toHaveScreenshot `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-page] › page/page-screenshot.spec.ts:​139:5 › page screenshot › should clip rect `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-page] › page/page-screenshot.spec.ts:​153:5 › page screenshot › should clip rect with fullPage `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-page] › page/page-screenshot.spec.ts:​197:5 › page screenshot › should run in parallel `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-page] › page/page-screenshot.spec.ts:​224:5 › page screenshot › should take fullPage screenshots and mask elements outside of it `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-page] › page/page-screenshot.spec.ts:​235:5 › page screenshot › should restore viewport after fullPage screenshot `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-page] › page/page-screenshot.spec.ts:​260:5 › page screenshot › should render white background on jpeg file `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-page] › page/page-screenshot.spec.ts:​327:5 › page screenshot › should work for webgl `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-page] › page/page-screenshot.spec.ts:​345:5 › page screenshot › should work while navigating `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-page] › page/page-screenshot.spec.ts:​425:5 › page screenshot › should work with Array deleted `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-page] › page/page-screenshot.spec.ts:​451:7 › page screenshot › mask option › should work `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-page] › page/page-screenshot.spec.ts:​477:7 › page screenshot › mask option › should mask multiple elements `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-page] › page/page-screenshot.spec.ts:​556:7 › page screenshot › mask option › should work when mask color is not pink #F0F `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-page] › page/page-screenshot.spec.ts:​565:7 › page screenshot › mask option › should hide elements based on attr `@webkit-ubuntu-22.04-node18`

46567 passed, 804 skipped


Merge workflow run.

@KentGu
Copy link

KentGu commented Sep 30, 2025

@dgozman do you have any ideas how we can insert local storages before visiting that site after the PR actually remove the setStorageState?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants